Skip to content

chore: Prepare kvm-bindings@0.14.0 and kvm-ioclts@0.24.0 release #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2025

Conversation

RuoqingHe
Copy link
Member

@RuoqingHe RuoqingHe commented Aug 14, 2025

Summary of the PR

Release kvm-bindings v0.14.0 and kvm-ioctls v0.24.0 to consume Rust edition change and newly exposed X2ApicApi capability.

Waiting for #338 to be merged first.

Relates: #339

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

The kvm crates does not use anything from vmm-sys-util v0.15, widen the
range to be compatible with other crates.

Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
@RuoqingHe RuoqingHe force-pushed the kvm-bindings-0.14-ioctls-0.24 branch 2 times, most recently from 9b0c9da to c78ddb5 Compare August 14, 2025 08:46
Release kvm-bindings v0.14.0 and kvm-ioctls v0.24.0 to consume Rust
edition change and newly exposed X2ApicApi capability.

Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
@RuoqingHe RuoqingHe force-pushed the kvm-bindings-0.14-ioctls-0.24 branch from c78ddb5 to 0bd25c0 Compare August 14, 2025 09:03
@roypat
Copy link
Member

roypat commented Aug 14, 2025

Actually, while we're at it, could you add two github workflow files like below, so that we automate the publishing to crates.io here as well:

.github/workflows/publish-kvm-bindings.yaml
name: Publish kvm-bindings to crates.io

on:
  push:
    tags: ['kvm-bindings-v*']  # Triggers when pushing tags starting with 'kvm-bindings-v'

jobs:
  publish:
    runs-on: ubuntu-latest
    # environment: release  # Optional: for enhanced security
    permissions:
      id-token: write     # Required for OIDC token exchange
    steps:
    - uses: actions/checkout@v4
    - uses: rust-lang/crates-io-auth-action@v1
      id: auth
    - run: |
        cd kvm-bindings
        cargo publish
      env:
        CARGO_REGISTRY_TOKEN: ${{ steps.auth.outputs.token }}
.github/workflows/publish-kvm-ioctls.yaml
name: Publish kvm-ioctls to crates.io

on:
  push:
    tags: ['kvm-ioctls-v*']  # Triggers when pushing tags starting with 'kvm-ioctls-v'

jobs:
  publish:
    runs-on: ubuntu-latest
    # environment: release  # Optional: for enhanced security
    permissions:
      id-token: write     # Required for OIDC token exchange
    steps:
    - uses: actions/checkout@v4
    - uses: rust-lang/crates-io-auth-action@v1
      id: auth
    - run: |
        cd kvm-ioctls
        cargo publish
      env:
        CARGO_REGISTRY_TOKEN: ${{ steps.auth.outputs.token }}

feel free to put my SoB if you add it in a separate commit :)

Add publish-kvm-bindings.yaml and publish-kvm-ioctls.yaml which use
rust-lang/crates-io-auth-action to automate crates publishing.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
Copy link
Member

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roypat roypat merged commit bd3260e into rust-vmm:main Aug 15, 2025
39 checks passed
@roypat
Copy link
Member

roypat commented Aug 15, 2025

(for anyone looking at this PR later and wondering why the workflows failed: I did the publishing manually for this, as at the time of merging I forgot to register the workflow on crates.io, and then I noticed I also didnt even have permissions to register the workflows in the first place - it's all sorted now though, so the next release should have working auto-publish 🎉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants