feat: add no_std support #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 周睿 <zrufo747@outlook.com>
roypat
added a commit
to roypat/rust-vmm-container
that referenced
this pull request
Sep 26, 2025
Some crates have a myriad of features, and it is very easy to accidentally mess up imports in a way that `cargo check --all-features` works, but only compiling with only a subset of features breaks. For this scenario, cargo check-all-features can help, as it will attempt to compile all feature permutations. We cannot currently add this to the default CI, as some crates in the rust-vmm ecosystem have incompatible features [1], but this unlocks at least testing all feature combinations for specific crates (for example, to ensure that no-std support does not accidentally break [2]). once the vm-memory / xen situation is fixed, this can also be added to the default CI. [1]: rust-vmm/vm-memory#317 [2]: rust-vmm/vm-allocator#107 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
added a commit
to roypat/rust-vmm-container
that referenced
this pull request
Sep 26, 2025
Some crates have a myriad of features, and it is very easy to accidentally mess up imports in a way that `cargo check --all-features` works, but only compiling with only a subset of features breaks. For this scenario, cargo check-all-features can help, as it will attempt to compile all feature permutations. We cannot currently add this to the default CI, as some crates in the rust-vmm ecosystem have incompatible features [1], but this unlocks at least testing all feature combinations for specific crates (for example, to ensure that no-std support does not accidentally break [2]). once the vm-memory / xen situation is fixed, this can also be added to the default CI. [1]: rust-vmm/vm-memory#317 [2]: rust-vmm/vm-allocator#107 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
4 tasks
roypat
added a commit
to roypat/rust-vmm-container
that referenced
this pull request
Sep 27, 2025
Some crates have a myriad of features, and it is very easy to accidentally mess up imports in a way that `cargo check --all-features` works, but only compiling with only a subset of features breaks. For this scenario, cargo check-all-features can help, as it will attempt to compile all feature permutations. We can even add this to the default CI, even for crates like vhost that have incompatible features, due to cargo-all-features allowing the elimination of incompatible features from the test matrix [1]. Some usecases where this could have been helpful is in vm-memory, where we have tens of feature permutations, and some of them invariably get broken regularly [2], or in crates that have no-std support that is offered via an opt-out 'std' feature [3] [1]: https://crates.io/crates/cargo-all-features#options [2]: rust-vmm/vm-memory#350 [3]: rust-vmm/vm-allocator#107 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
|
Hey, thanks for your contribution! This looks fine, but I'm sorta holding off on merging this until we get our CI into a place where we can compile-test different feature permutations, to make sure this feature doesn't get accidentally broken again (unless you're in a hurry to get no_std support for this crate?), e.g. see rust-vmm/rust-vmm-container#139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
For no_std usecase.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.