Open
Conversation
The following crates have been updated to a newer version kvm-ioctls 0.13.0 kvm-bindings 0.6 vmm-sys-util 0.11.2 event-manager 0.3.0 Signed-off-by: Alvise Rigo <a.rigo@virtualopensystems.com> Reviewed-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
arigo-vos
requested review from
alexandruag,
andreeaflorescu and
lauralt
as code owners
Member
|
@arigo-vos The tests are failing, can you please fix them? |
Author
Ouch. I think some of the errors are due to the fact |
The new version of vm-memory requires to bump the log crate to version
0.4.20 and vm-virtio to 0.10.0. This has various consequences to the
rest of the code. In particular:
The vmm crate had to be reworked to add a reference to the guest memory
in various places as it is not part of the Queue struct anymore. For
this reason, it is preferable to wrap the array of Arc<GuestRegionMmap>
with an Arc reference to optimize the various clone() operation that
will be added. This has the advantage of reducing the duplication of
memory and makes sure the various parts of the code to see the same
array of elements (which would not be the case if we clone the array of
Arc<> iteself). While at it, the reference to the guest memory was added
to some key virtio functions.
devices::virtio::{self, block, net} had all to be updated to also accept
the Arc reference to the guest memory.
Signed-off-by: Alvise Rigo <a.rigo@virtualopensystems.com>
Reviewed-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
Signed-off-by: Alvise Rigo <a.rigo@virtualopensystems.com> Reviewed-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
Update to align to the new Cmdline API and kernel image loader. While at it, update the load_kernel() tests as well. Signed-off-by: Alvise Rigo <a.rigo@virtualopensystems.com> Reviewed-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
arigo-vos
force-pushed
the
update-dependencies
branch
from
eae835f to
5b5524f
Compare
Signed-off-by: Alvise Rigo <a.rigo@virtualopensystems.com>
arigo-vos
force-pushed
the
update-dependencies
branch
from
5b5524f to
a24e199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This is a pull request that update the vmm-reference crate dependencies to:
linux-loader = { version = "0.10.0", path = "../linux-loader" }inCargo.toml) as it requires one commit that must be merged upstream. For this, I created another pull request. As soon as the commit will be upstreamed I'll update this pull request to pull linux-loader directly from github.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.