Skip to content

Add ROCm 6.4.3+ support #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ROCm 6.4.3+ support #498

wants to merge 1 commit into from

Conversation

Looong01
Copy link

Because ROCm 6.4.3 implements stricter type checking in the HIP warp shuffle API, code that previously compiled in 6.4.2 now triggers a static_assert at compile time.

The error message reads:
static assertion failed due to requirement 'sizeof(unsigned int) == 8': The mask must be a 64-bit integer

This is because ROCm 6.4.3's __shfl_sync / __shfl_up_sync / __shfl_down_sync function templates now require the mask parameter to be a 64-bit integer (uint64_t), but your code is passing an unsigned int (32-bit), resulting in a compilation failure.

Reason for Change
In the HIP header file (amd_warp_sync_functions.h) of ROCm 6.4.3, AMD added the following:
static_assert(sizeof(MaskT) == 8, "The mask must be a 64-bit integer...");

This was added to unify the behavior and avoid potential errors caused by implicit type promotion.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.20%. Comparing base (140d3ad) to head (9799c51).
⚠️ Report is 20 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   97.23%   98.20%   +0.97%     
==========================================
  Files          10       10              
  Lines         217      223       +6     
==========================================
+ Hits          211      219       +8     
+ Misses          6        4       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants