Add ROCm 6.4.3+ support #498
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because ROCm 6.4.3 implements stricter type checking in the HIP warp shuffle API, code that previously compiled in 6.4.2 now triggers a static_assert at compile time.
The error message reads:
static assertion failed due to requirement 'sizeof(unsigned int) == 8': The mask must be a 64-bit integer
This is because ROCm 6.4.3's __shfl_sync / __shfl_up_sync / __shfl_down_sync function templates now require the mask parameter to be a 64-bit integer (uint64_t), but your code is passing an unsigned int (32-bit), resulting in a compilation failure.
Reason for Change
In the HIP header file (amd_warp_sync_functions.h) of ROCm 6.4.3, AMD added the following:
static_assert(sizeof(MaskT) == 8, "The mask must be a 64-bit integer...");
This was added to unify the behavior and avoid potential errors caused by implicit type promotion.