feat: implement sart instrument #1233
Conversation
Signed-off-by: rahul810050 <rahul810050@gmail.com>
|
@marcgc21 @KarinePistili @sahitya-chandra could you please review it ?? |
|
Instead of using the full string, use just SART: 
|
|
Delete SART summary, the user doesn't need to know what are the value because he/she is just answering: |
|
On SART analytics view it should be done some modifications to match the technique: On top show:
On SART dimension breakdown:
On Individual SART Scores:
On detail view analytics SART Score:
|
|
Thanks for the clarification !! i will update the code according to your feedback @marcgc21 |
|
I think that there are conflicts on the language files |
|
@marcgc21 resolved the conflict. now it is fine |
|
Still have problems. Please take your time to review correctly the PR before uploading again 🙏 
|
|
@marcgc21 really sorry about that🙏 I will update the pr asap |
|
@marcgc21 I have fixed the error. now it is working perfectly fine. once again really sorry about that mistake... |
|
@rahul810050 we still have problems about SART methodology. You can check this paper: Basically what it says is that Supply has 4 dimensions ant not 7:
And "Understanding" has:
So basically you are grouping Supply and Understanding. Try to fix this problem and I beliave everything will be done! |
src/ux/UserTest/utils/sartData.js
Outdated
| category: 'supply' | ||
| }, | ||
| { | ||
| key: 'understanding', |
There was a problem hiding this comment.
This should be the category "Understanding (U)"
| category: 'supply' | ||
| }, | ||
| { | ||
| key: 'informationQuantity', |
There was a problem hiding this comment.
InformationQuantity, InformationQuality and Familiarity are from "Understanding" category
Please update the PR description to address these issues. |
github-actions
bot
added
high-complexity
needs-description
new-feature
|
@marcgc21 i have updated according to your feedback comments research paper. Just so you know i have changed the ui of sartForm a bit like put some colors according to dimensions just to make it a bit cool. if it seems wrong to you then i can make the ui as same as nasatlx form ui. let me know if you want exact that... |
@rahul810050 can you take a look on that? Also we have fixed the lint action and it is reporting that the code is not fulfilling the requeriments. Can you also take a look on that? Regardind the feature I bet that it is already done, let's finish that and will finally merge it! |
|
@marcgc21 i could be wrong but i raised this pr before the updated github actions that is why i think it still uses the previous github actions that is why it is failing.... for example for this #1152 i raised a pr #1199 where i used the same logic in useProfile.js(which fails in two actions same as this current pr) like duplicate staff that i also used in this pr #1266 in ProfileView.vue (but this is the latest develop branch code) and guess what it passes all the checks...i think you get the point marc!!! if you want i can again raise a new pr for this just to pass the github action let me know if you want that !!! |
|
Hi @rahul810050 I reviewed the lint and it looks like only appears the files that you have modified, so I beliave that it is using the new version |
|
whole files got lint error I fixed all the files !!! @marcgc21 if you dont want that i will revert these changes |
|
@rahul810050 the problem now is that you applied the lint to the whole project... You need to do it just to the files that you have modified. So please revert the commit to the proper point of time and update it. |
rahul810050
force-pushed
the
feat/implement-sart-instrument
branch
from
8fd9ed8 to
8a08047
Compare
|
@marcgc21 i have reverted the changes. please feel free to review it |
|
2 participants
Fixed Issue: #1211
Video Explanation: https://app.screencastify.com/watch/OMyACxMNXrvO63ta9u6G