test: add unit tests for EmailController and ReportController

[pranav718]

Summary

Continuation of #1089 - adding unit tests for the remaining untested controllers as suggested by @marcgc21.

This PR adds 12 new unit tests for:

• EmailController (5 tests) - axios-based email sending
• ReportController (7 tests) - Firestore report removal

Changes

File	Status
tests/unit/EmailController.spec.js	NEW
tests/unit/ReportController.spec.js	NEW

Test Coverage

EmailController

• Structure verification
• Axios POST with correct URL/payload
• Success/error response handling

ReportController

• HEURISTIC type → heuristicAnswers field
• USER type → taskAnswers field
• User/answer document existence checks
• Error handling

Testing

npm test -- --testPathPattern="EmailController|ReportController"

[github-actions]

⚠️ PR Description Issues Detected

• Missing issue reference (e.g., 'Fixes Graphics #123')

Please update the PR description to address these issues.

[marcgc21]

@pranav718 everything seems okay just the SonarCloud is failing due to duplicated code. Can you make something to make the files more reusable?

[pranav718]

Thanks for the feedback @marcgc21!

I'll refactor the test files to reduce duplication by:

1. Creating a shared tests/unit/helpers/testUtils.js with reusable utilities:

   • createControllerSpies()- which will extract repetitive spy setup for parent controller methods
   • createMockDoc()- helper for creating mock firestore documents

2. Refactoring ReportController.spec.js to use these shared helpers (which will reduce the number of lines from ~225 to ~100 lines)

The duplicated code % will reduce a lot with this.

Will push the changes shortly!

[marcgc21]

Hi @pranav718, just one question, when you run the npm run test, it appears something like that?

[pranav718]

Hi @marcgc21! Sorry about that! Yes, you're right, those console.error messages were appearing in the test output. I should have caught that earlier.

Those were expected errors from the error handling test cases, but they were cluttering the output and making it look messy. My apologies for the oversight!

I've fixed this by mocking console.error in both test files during beforeEach and restoring it in afterEach. The tests still verify the error handling behavior correctly, but now the output is clean:

Thanks for pointing this out

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud