-
Notifications
You must be signed in to change notification settings - Fork 233
fix(i18n): ensure complete UI localization across all languages #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix(i18n): ensure complete UI localization across all languages #1295
Conversation
|
@marcgc21 @sahitya-chandra please review |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
666da93 to
bfa11af
Compare
bfa11af to
c563f81
Compare
marcgc21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take care with the merging strategy that you are following, all the language files has git merging traces like:
<<<<<<< HEAD
or
=======
Please update that!
marcgc21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, most of the files has lint problems, you need to fix them using the:
npx eslint --fix
|
@marcgc21 Thanks for the review and for pointing this out. You’re absolutely right the language files had merge conflict markers left due to an incorrect merge/rebase flow earlier. I’m cleaning up all localization files to remove any remaining git merge traces (<<<<<<<, =======, >>>>>>>) and ensuring the JSON is valid across all locales. I’ll also run npx eslint --fix and address any remaining lint issues across the affected components. I’ll push an updated commit shortly. Thanks for the heads-up! |
72361b7 to
b17df00
Compare
|
@marcgc21 everything fixed |
|
@marcgc21 I wanted to check if you’d like me to continue working on translating the remaining pages/components as well, or if there’s a specific area you’d prefer me to focus on next. Happy to proceed based on your guidance. Thanks! |
|
@marcgc21 all done |
6495f3c to
ee3d76e
Compare
|




This PR fixes a global i18n issue where switching to non-English languages resulted in a partially translated UI.
Changes include:
Closes #1294
BEFORE
-HINDI
-JAPANESE
AFTER
-HINDI
-JAPANESE
all other languages have changed too