Skip to content

Conversation

@revaarathore11
Copy link

This PR fixes a global i18n issue where switching to non-English languages resulted in a partially translated UI.

Changes include:

  • Removed hardcoded English strings
  • Added missing translation keys across all locale files
  • Ensured dashboard and navigation fully respect the selected language

Closes #1294

BEFORE

-HINDI

image

-JAPANESE

image

AFTER

-HINDI

image

-JAPANESE

image

all other languages have changed too

@revaarathore11
Copy link
Author

@marcgc21 @sahitya-chandra please review

@gitguardian
Copy link

gitguardian bot commented Jan 6, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@revaarathore11 revaarathore11 force-pushed the fix/i18n-mixed-language-ui branch 2 times, most recently from 666da93 to bfa11af Compare January 6, 2026 11:17
@revaarathore11 revaarathore11 force-pushed the fix/i18n-mixed-language-ui branch from bfa11af to c563f81 Compare January 6, 2026 11:26
Copy link
Member

@marcgc21 marcgc21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take care with the merging strategy that you are following, all the language files has git merging traces like:

<<<<<<< HEAD

or

=======

Please update that!

Copy link
Member

@marcgc21 marcgc21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, most of the files has lint problems, you need to fix them using the:

npx eslint --fix

@revaarathore11
Copy link
Author

@marcgc21 Thanks for the review and for pointing this out.

You’re absolutely right the language files had merge conflict markers left due to an incorrect merge/rebase flow earlier. I’m cleaning up all localization files to remove any remaining git merge traces (<<<<<<<, =======, >>>>>>>) and ensuring the JSON is valid across all locales.

I’ll also run npx eslint --fix and address any remaining lint issues across the affected components.

I’ll push an updated commit shortly. Thanks for the heads-up!

@revaarathore11 revaarathore11 force-pushed the fix/i18n-mixed-language-ui branch from 72361b7 to b17df00 Compare January 6, 2026 16:33
@revaarathore11
Copy link
Author

@marcgc21 everything fixed
including the git merging traces and eslint.

@revaarathore11
Copy link
Author

@marcgc21 I wanted to check if you’d like me to continue working on translating the remaining pages/components as well, or if there’s a specific area you’d prefer me to focus on next.

Happy to proceed based on your guidance. Thanks!

@revaarathore11
Copy link
Author

@marcgc21 all done
please review

@revaarathore11 revaarathore11 force-pushed the fix/i18n-mixed-language-ui branch from 6495f3c to ee3d76e Compare January 7, 2026 16:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐞 BUG]: Language switch results in partially translated UI across all non-English languages

2 participants