Skip to content

Update to work with latest stdlib#30

Merged
rvcas merged 1 commit intorvcas:mainfrom
mna:main
Jan 26, 2025
Merged

Update to work with latest stdlib#30
rvcas merged 1 commit intorvcas:mainfrom
mna:main

Conversation

@mna
Copy link
Contributor

@mna mna commented Dec 28, 2024

Hello,

This fixes some breaking changes introduced by Gleam's stdlib in later versions (deprecated packages replaced by external ones, and renamed functions in the string package). The gleam version constraint is to remove a warning due to the use of the @internal annotation:

warning: Incompatible gleam version range
   ┌─ .../ids/src/ids/typeid.gleam:10:1
   │
10 │ @internal
   │ ^^^^^^^^^ This requires a Gleam version >= 1.1.0

The `@internal` annotation was introduced in version v1.1.0. But the Gleam
version range specified in your `gleam.toml` would allow this code to run
on an earlier version like v0.32.2, resulting in compilation errors!
Hint: Remove the version constraint from your `gleam.toml` or update it to be:

    gleam = ">= 1.1.0"

Thanks!
Martin

@dandeduck
Copy link

I opened #31 just to realize you already did the exact same thing... 🤦🏻

@dandeduck
Copy link

@rvcas can this be merged please? It's blocking dependents from upgrading their stdlib

@rvcas
Copy link
Owner

rvcas commented Jan 26, 2025

@dandeduck yes, I'm very sorry, I don't know why I never saw this

@rvcas rvcas merged commit 8fc37cf into rvcas:main Jan 26, 2025
1 check failed
@rvcas
Copy link
Owner

rvcas commented Jan 26, 2025

@dandeduck
https://github.com/rvcas/ids/releases/tag/v0.14.0

@dandeduck
Copy link

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants