feat: gate planning agent — no activities/cards until project plan approved#6
Open
feat: gate planning agent — no activities/cards until project plan approved#6
Conversation
…ean up ephemeral files Delete all 9 strategy documents — built functionality captured as ADRs (0010–0015), unbuilt plans moved to docs/Feature Plans/. Delete 18 ephemeral files (work plans, fix plans, verification reports, superseded and expired investigations). Update SYSTEM_ARCHITECTURE.md as master doc, fix docs-index.yaml, README, and all source code @see references to point to current domain docs instead of deleted files. Made-with: Cursor
…rack active investigation Add electron/*.js and electron/bin/ to .gitignore (compiled output from tracked .ts sources). Delete counter-app-demo/ test artifact. Commit active investigation report for build-card-stuck-building. Made-with: Cursor
- Add project.finalized_at to schema and map snapshot so planning context includes approval state - Planning prompt: require project.finalized_at set before generating createActivity, createCard, or upsertCardPlannedFile; otherwise respond with clarification to use Approve Project first - Chat route: return 400 for mode=populate when project not finalized; return clarification for auto-populate intent when not finalized - Chat route: server-side filter drops createActivity/createCard/ upsertCardPlannedFile when project not finalized (even if LLM returns them) - Chat stream route: emit error and skip populate when project not finalized - Tests: add populate-rejects-when-not-approved; update populate mock test to set finalized_at so flow still passes Made-with: Cursor
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createActivity,createCard, orupsertCardPlannedFileactions until the project plan is approved (finalized_atis set)finalized_atin the map snapshot and project schema so the gate check has data to work withTest plan
populate returns error when project plan is not approvedfinalized_atbefore populating)Made with Cursor