Adding tests, rockspec file, and TravisCI integration#4
Adding tests, rockspec file, and TravisCI integration#4subnetmarco wants to merge 2 commits intorxi:masterfrom
Conversation
|
Sorry for the commit mess. To recap, what this pull request does is just adding rockspec support to the project, with some basic testing. I brought back the By merging this pull request the project could also be easily distributed on https://rocks.moonscript.org, which is my ultimate goal. After merging this pull request TravisCI needs to be enabled as specified in my first message. |
|
hi @rxi, did you have any chance to review this pull request? |
|
Hey, Sorry for the slow response! Would you mind closing this pull request and instead submit the rockspec addition as a separate pull request, ideally with a cleaner commit history? Although I'm happy with the idea of the library including some tests, I would prefer they used mixedCase rather than snake_case (as to match the formatting in the project's examples). The use of "say" functions returning a string also doesn't seem to sit right, as I feel it implies the string is printed rather than returned. The test which is listed as using a static method call the method using the I may be more comfortable writing some small tests myself, as it is, due to my unfamiliarity with busted, I wouldn't be able to add any additional tests to the project if I wanted to in the future. I would likely opt for doing testing the same way I do with lume. Thanks |
|
@rxi I have implemented all but one of those changes and cleaned the commit history without needing to create a new pull request. The only thing that I didn't implement is replacing busted with another library, busted is a very powerful testing library and provides lots of built-in features for handling complex scenarios. For example the check to make sure no arguments are being passed to the static methods has been implemented with Spies: subnetmarco@1041afa#diff-a5bbebb071dab977909b22acfa4e1563R47 |
This pull request includes a
rockspecfile for the project, and two tests built withbustedthat can be extended in the future. It also includes a.travis.ymlfile for Travis CI, and an updatedREADME.mdfile that shows the status of the latest build.Enabling Travis CI
In order to enable the Travis CI builds, a TravisCI webhook needs to be applied to the repository. That will trigger Travis CI on every push to the
masterbranch. Once this is done, the first line of theREADME.mdfile needs to be updated too, to point to the proper build image, so that this text:[](https://travis-ci.org/thefosk/classic)becomes:
[](https://travis-ci.org/rxi/classic)