Conversation
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a small class commons implementation that passes all class commons tests.
EDIT: I should probably add some context:
Class Commons is a project to allow libraries to write against a common class interface. That way, the author can use classes in their libraries, yet the user can use those classes with their library of choice. Meaning they can subclass your (library) classes, or vice versa, they can instantiate them as they would any other classes, you can instantiate their classes, and all that goodness.
I wrote this because I saw a post on the love forums of someone wanting to use classic with HC, which supports Class Commons.