Open
Conversation
|
there has been a new community fork of this repository. the community is looking to add some new simple features. please feel free to try your PR over there. |
Rubo3
reviewed
Jan 30, 2026
| static int logbuf_updated = 0; | ||
| static float bg[3] = { 90, 95, 100 }; | ||
|
|
||
| /* make context global because we need it in glfw callbacks */ |
There was a problem hiding this comment.
The global context is not needed, you can call glfwSetWindowUserPointer(window, ctx) in main and glfwGetWindowUserPointer(window) in the callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added this as an example.
I stumbled upon the GDI demo PR recently and wondered, "Why don't we have a GLFW implementation?" So, I wrote a basic implementation.
It's pretty raw right now - I hashed it out in about an hour while flipping through the GLFW docs. I mostly omitted error handling, and moved input processing to glfw callbacks. There are some tweaks in the function signatures (like r_init, r_present), mainly because certain GLFW functions needed the GLFWwindow parameter.
I tested this in MinGW64 (MSYS2). To compile you need to install
glfwandpkg-configpackages (or replacepkg-config --libs glfw3with-L<path-to-libglfw> -lglfw3inbuild.sh). To install these packages (in MSYS2) run: