Relative times with languages support#20
Open
ohanhi wants to merge 3 commits intoryan-haskell:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a daring PR out of the blue, so feel free to disagree with my decisions and/or point out issues I might not have noticed. I introduced a new module:
DateFormat.Relative.Language. Then I moved theRelativeTimeOptionsalong with the default (now calledenglish) to that module. Finally, I localized the relative time options for Finnish.Because of the type moved from
DateFormat.RelativetoDateFormat.Relative.Language(to avoid circular imports), this change would be a major version. If you'd really like to avoid that, there's at least two ways to do it:type alias MyType = Module.MyType, which can be confusing for people (which one do they need to import to be able to construct a record?)DateFormat.Relative.Languagefor type signature purposesNote: This builds on #19, the first two commits are in common with it. 6181ece is where the actual changes happen.