Merge ttblue repository into ttwatch#170
Open
Grimler91 wants to merge 248 commits intoryanbinns:masterfrom
Open
Merge ttblue repository into ttwatch#170Grimler91 wants to merge 248 commits intoryanbinns:masterfrom
Grimler91 wants to merge 248 commits intoryanbinns:masterfrom
Conversation
…mands compile with: gcc ttblue.c -lbluetooth -o ttblue --std=c99 -I $BLUEZ_SRC/src/shared
… even if the host doesn't
…run it faster by minimizing connection interval
PS: using C I now realize why it's convenient to have the length as the first bit of the list files reply. Thanks TomTom :-P
I, clearly, didn't test --set-time before but now it works.
Add preference file to tt_files and fix manifest address
Thanks to @galou for reporting it and for detailed tests.
I haven't been able to capture a re-auth sequence matching the one here for either v1 or v2 devices. The re-auth sequence work however, for both device types, so only reason to remove it is to match the captured android traffic exactly.
Will test v2 code on v1 device when I have the opportunity
Update tt_reboot with new reset command to make it work again
Pairing simplification
Remove structs with files as they are mostly identical between V1 and V2 devices. Use similar format as the ttwatch project do, to simplify a potential future merge of the projects. Some interesting information: * There seem to be 11 bluetooth commands in total used by the android app * There are at least 3 types of notifications: phone call, text message and voice mail/misc.(?)
Add new var read_code and read -c argument into it and then strcpy into dev_code. (Mostly because I couldn't figure out how to read the popt arg into a char[])
Necessary if we want to be able to merge ttblue with nicely.
poptGetContext returns the int specified in the 5th position in the poptOption struct.
Packages seem to arrive in the wrong order sometimes during pairing sequence. With this it does not fail, but it is not a proper fix.
Also gather all cmake modules in one place.
Contributor
I don't have a strong preference, honestly, but happy to see them merged if desired. The coding style I used in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ping @dlenski.
As TomTom has, regrettably, stopped producing watches we will most likely not see a lot of additional development when it comes to ttwatch and ttblue.
It would be nice to gather all the gathered knowledge about the watches and how they behave in one repository, to better preserve it for the future. In this pull request I have added all the ttblue commits to a subfolder ttblue in the ttwatch repository (using the technique outlined in https://stackoverflow.com/a/6442034), this keeps the git history of both repositories intact.
I have added a
-Dttblue=on(on per default) option to ttwatch's CMakeLists.txt, if a user do not want to build ttblue they can hence configure ttwatch withcmake -Dttblue=off .Another important note is that ttblue and ttwatch uses different licenses (GPL and MIT), so combining files from the two projects would not be possible unless one project is re-licensed (I think that is how it works).
Merging ttwatch and ttblue has previously been discussed in #35.
So, @dlenski, @ryanbinns, what do you think of this?