Skip to content

The process property prevented accurate viewable permission responses. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LostKobrakai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

The process property prevented accurate viewable permission responses. #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions DynamicRoleSupport.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,10 +521,14 @@ class DynamicRoleSupport extends WireData implements Module, ConfigurableModule
$query = $this->wire('database')->prepare($sql);
$query->bindValue(':id', $page->id);
$query->execute();
}
}

// We're not interested in any process related permissions
$tempProcess = $page->process;
$page->process = null;

$guest = $this->wire('users')->get('guest');
$guestViewable = $page->viewable($guest);
$guest = $this->wire('users')->get('guest');
$guestViewable = $page->viewable($guest);

foreach($this->wire('droles') as $drole) {

Expand Down Expand Up @@ -564,7 +568,10 @@ class DynamicRoleSupport extends WireData implements Module, ConfigurableModule
break;
}
}
}
}

// Reset nullified process for page
$page->process = $tempProcess;

// if something is editable, it must also be viewable
if(($editable || $addable) && !$viewable) $viewable = true;
Expand Down