bug fix for gdl90_escape_message_for_tx()#1
Open
aaknitt wants to merge 2 commits intoryandavid:masterfrom
Open
bug fix for gdl90_escape_message_for_tx()#1aaknitt wants to merge 2 commits intoryandavid:masterfrom
aaknitt wants to merge 2 commits intoryandavid:masterfrom
Conversation
bug fix for incorrect escaping that results in an invalid message and bad CRC. Original code assumes that first flag byte and message ID byte are inside the data[] array within the rawMsg->data[] array but they are actually separate fields within the gdl_message_t struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug fix for incorrect escaping that results in an invalid message and bad CRC. Original code assumes that first flag byte and message ID byte are inside the data[] array within the rawMsg->data[] array but they are actually separate fields within the gdl_message_t struct.