Redesign CLI parsing subsystem to reduce boilerplate and improve readability#423
Merged
ryanfowler merged 1 commit intomainfrom Feb 11, 2026
Merged
Redesign CLI parsing subsystem to reduce boilerplate and improve readability#423ryanfowler merged 1 commit intomainfrom
ryanfowler merged 1 commit intomainfrom
Conversation
Owner
ryanfowler
commented
Feb 11, 2026
ryanfowler
commented
- Add core.CutTrimmed to deduplicate cut() between cli and config packages
- Consolidate error types (MissingEnvVarError, fileIsDirError) into errors.go
- Extract parseURL to deduplicate URL normalization between ArgFn and applyFromCurl
- Replace dataSet/jsonSet/xmlSet booleans with bodySource enum
- Create flags.go with declarative helpers (boolFlag, ptrBoolFlag, stringFlag, cfgFlag)
- Extract 15 flag handler methods and buildAWSConfig to deduplicate AWS config construction
- Rewrite CLI() using helpers, reducing it from ~1,000 to ~230 lines
- Unify validation with declarative SchemeExclusiveFlags and FromCurlExclusiveFlags
…ability - Add core.CutTrimmed to deduplicate cut() between cli and config packages - Consolidate error types (MissingEnvVarError, fileIsDirError) into errors.go - Extract parseURL to deduplicate URL normalization between ArgFn and applyFromCurl - Replace dataSet/jsonSet/xmlSet booleans with bodySource enum - Create flags.go with declarative helpers (boolFlag, ptrBoolFlag, stringFlag, cfgFlag) - Extract 15 flag handler methods and buildAWSConfig to deduplicate AWS config construction - Rewrite CLI() using helpers, reducing it from ~1,000 to ~230 lines - Unify validation with declarative SchemeExclusiveFlags and FromCurlExclusiveFlags
ryanfowler
force-pushed
the
refactor/cli-parsing-redesign
branch
from
d35ef86 to
e8e0ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.