Merged
Conversation
Add t.Parallel() to all 132 subtests so they run concurrently. Eliminate shared mutable state that prevented parallelization: - Replace os.Setenv with cmd.Env via new runFetchOpts helper - Replace os.Chdir with cmd.Dir via fetchOpts - Replace shared tempDir with per-test t.TempDir() - Copy binary for update test to avoid modifying shared fetchPath - Use t.Cleanup instead of defer for servers shared by parallel subtests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t.Parallel()to all 132 subtests so they run concurrentlyos.Setenvwithcmd.Envvia newrunFetchOptshelper (aws-sigv4, update, session tests)os.Chdirwithcmd.DirviafetchOpts(6 output/remote-name tests)tempDirwith per-testt.TempDir()(unix socket, mtls, inspect-tls, session)fetchPatht.Cleanupinstead ofdeferfor servers shared by parallel subtests (grpc client streaming, mtls, inspect-tls)Test plan
go test ./...passesgo test -race ./integration/...passes (no data races)gofmt -l .reports no formatting issues