Introduce formatter registry to eliminate formatResponse() function#426
Merged
ryanfowler merged 1 commit intomainfrom Feb 13, 2026
Merged
Introduce formatter registry to eliminate formatResponse() function#426ryanfowler merged 1 commit intomainfrom
ryanfowler merged 1 commit intomainfrom
Conversation
ryanfowler
force-pushed
the
formatter-registry
branch
from
347c806 to
caa20a9
Compare
Move ContentType enum, GetContentType(), and SniffContentType() into the format package and add a registry pattern with BufferedFormatter and StreamingFormatter types. Each formatter self-registers via init(), replacing the hardcoded switch statements in formatResponse() with registry lookups. Special cases (gRPC streaming, Protobuf with descriptor, Image rendering) remain inline due to extra context needs.
ryanfowler
force-pushed
the
formatter-registry
branch
from
caa20a9 to
1474a57
Compare
ryanfowler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ContentType enum, GetContentType(), and SniffContentType() into the format package and add a registry pattern with BufferedFormatter and StreamingFormatter types. Each formatter self-registers via init(), replacing the hardcoded switch statements in formatResponse() with registry lookups. Special cases (gRPC streaming, Protobuf with descriptor, Image rendering) remain inline due to extra context needs.