Merged
Conversation
…ests for head_extra metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how favicon links are managed in the static site generator. The favicon is no longer hardcoded in the HTML builder; instead, it is now included via the
head_extraconfiguration, allowing for more flexible and customizable head content. Related tests and configuration files have been updated to reflect this change.Configuration and Metadata Handling:
<link rel='icon' type='image/x-icon' href='/favicon.ico'>) to thehead_extralist inconfig.json, making favicon management part of the site configuration instead of hardcoded in the HTML builder.head_extraarray, ensuring test coverage for the new approach.HTML Builder and Rendering:
favicon_linkparameter and its usage from theHTMLRootLayoutBuilder.get_doc_headmethod, so favicons (and other head elements) are now injected viahead_extra.Testing Updates:
test_data_loader.pyto expect the favicon link as part of thehead_extrametadata, adjusting assertions and indices accordingly.Miscellaneous:
0.0.1a3to0.0.1a4inpyproject.toml.