Move characters up when auto-hidden dock appears#5
Open
devpras22 wants to merge 4 commits intoryanstephen:mainfrom
Open
Move characters up when auto-hidden dock appears#5devpras22 wants to merge 4 commits intoryanstephen:mainfrom
devpras22 wants to merge 4 commits intoryanstephen:mainfrom
Conversation
- Accumulate streaming text in ClaudeSession.currentResponseText and commit to history on turn complete, so messages persist when switching between agents - Queue messages sent before CLI process is ready via pendingMessages, flushed once the process launches - Add safe pipe writes with do/catch to prevent crashes if Claude process dies mid-communication - Remove duplicate currentStreamingText accumulation from WalkerCharacter
Save selected theme name to UserDefaults on switch and restore it on launch instead of always defaulting to Peach.
Track mouse position via NSEvent.mouseLocation. When cursor enters the dock trigger zone (within 5px of screen bottom), smoothly animate characters up by the estimated dock height (tileSize + 22). When cursor moves away, characters glide back down.
devpras22
force-pushed
the
fix/autohide-dock-tracking
branch
from
dc7827e to
591ba50
Compare
Owner
|
Hi, mouse tracking at 60fps is a dealbreaker. NSEvent.mouseLocation is polled every frame in tick() when dock auto-hide is active. Even though the position isn't stored or transmitted, continuously reading cursor coordinates feels wrong. Is there another approach for this? |
Use NSEvent global + local mouse-moved monitors instead of polling NSEvent.mouseLocation every frame. The monitors only fire when the cursor actually moves, eliminating continuous reads while maintaining the same smooth character animation when the dock appears.
Author
|
Good point. I've redone it using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSEvent.mouseLocationto detect when the auto-hidden dock trigger zone is activetilesizepreference (tileSize + 22), works across all screen sizesTest plan
🤖 Generated with Claude Code