Skip to content

Add numpy to requirements.txt#22

Open
D4D3VD4V3 wants to merge 1 commit intoryanzhumich:masterfrom
D4D3VD4V3:patch-1
Open

Add numpy to requirements.txt#22
D4D3VD4V3 wants to merge 1 commit intoryanzhumich:masterfrom
D4D3VD4V3:patch-1

Conversation

@D4D3VD4V3
Copy link
Copy Markdown

run.py imports numpy which is not specified in requirements.txt

@de-viant
Copy link
Copy Markdown

same with 'six', it tries to import but it isn't present in requirements.txt

@m1nhtu99-hoan9
Copy link
Copy Markdown

This repo is abandoned by the author, I guess.

However, as numpy is already a peer dependency implicitly required by torch, I think adding it to requirements.txt doesn't make a difference. But the case for six, I do think that it needs to be present in requirements.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants