Skip to content

Make use of editorservice as it's better than overlay#8

Open
patrickdemooij9 wants to merge 1 commit intorydigital:masterfrom
patrickdemooij9:feature/EditorService
Open

Make use of editorservice as it's better than overlay#8
patrickdemooij9 wants to merge 1 commit intorydigital:masterfrom
patrickdemooij9:feature/EditorService

Conversation

@patrickdemooij9
Copy link
Copy Markdown
Contributor

2 Changes here:

  • Use the editorservice for infinite editing instead of overlays. I think overlays won't be supported in the future as you cannot even find them in the Umbraco 8 documentation anymore.
  • Broadcast "formSubmitting" when submitting any changes. I had some problems with the timing of data saving when using Macro's. The data sync on the macro would occur after the data was added to the cell in some instances. With the broadcast, every item under it will sync their content so that we have the most up to date information ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants