Note about the DirectShow AVI writer, and fix for BASS interception to correctly handle older versions of BASS.DLL#4
Open
joncampbell123 wants to merge 36 commits intorygorous:masterfrom
Open
Conversation
…e older BASS 1.x API because BASS_Init() changed the number of parameters. Use BASS_GetVersion() to automatically detect older vs newer BASS_Init() so interception works in both cases.
…d will throw an error otherwise
…apture even if the version of VS does not have the DirectShow SDK
allow KKapture to compile whether you use VS2010 or VS2022.
…o KKapture interface. Instead of intercepting a demo, KKapture directly calls the AVI writer and generates a test pattern, then exits
…ted writer is nice but slight audio errors are audible between segments when joined together in an editor
… in the target demo
… can cause a segfault
… need to Alt+Tab away
…ter to 0xDDDDDDDD on delete and that causes the process frame function to be called with invalid pointers that crash. Fix possible case where wave out frame processing can get stuck in an infinite loop.
…ames so that audio and timing can be more precise, and then write a video frame once every video frame. Microframes of course have a fixed integer relationship to video frames
…ls (when demos present a dialog box), fix it
…on controls, fix IDirectSound GetCaps(), set IDirectSoundBuffer WriteCursor() to play position plus 15ms as documented by Microsoft for old emulated DirectSound devices, fix IDirectSoundBuffer and waveOutWrite to round buffer size down to a multiple of nBlockAlign to avoid audio glitches whenever demos use some odd size that is not a multiple (Wonder by Sunflower)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KKapture 1.02 has been unable to capture some older demos because the older demos use a version of BASS.DLL where the init function has four, rather than 5 parameters. However there is a BASS_GetVersion() function which can be used to auto-detect whether the demo uses the newer or older BASS.DLL to avoid this crash.
For whatever reason KKapture 1.01 and earlier had no problems with the same older demos.
This fixes "Liquid Wen", "Mikrostrange", and anything that uses the older BASS.DLL interface.