Skip to content

Conversation

@rylnd
Copy link
Owner

@rylnd rylnd commented Apr 24, 2015

@hlangeveld I pulled this out of #59. It should close #65, but as it stands it won't work. See comments below.

Except for an example test, `shpec` itself does
not check the results of a sourced file.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even in the original branch, ${_shpec_file} is not defined here. If there's not an easy way to get the name of the file, I'd rather just omit that part for now.

Also, I was unable to find any documentation on the -u option for printf. What does it do, is it needed, and can we use our internal echoe instead?

@hlangeveld
Copy link
Collaborator

Uh-oh, I morphed $file into $_shpec_file in a premature attempt to use a reserved namespace for shpec internal variables.

I need to check on -u, hangon ...

Yeah, that needs to go. POSIX Shell & Utilities says

OPTIONS

    None.

What -u <fd> is expected to do, is to change the output fd. It's more concise than the traditional >& 2, and that's what it will be...

@rylnd
Copy link
Owner Author

rylnd commented Apr 24, 2015

Closing in favor of #71.

@rylnd rylnd closed this Apr 24, 2015
@rylnd rylnd removed the in progress label Apr 24, 2015
@rylnd rylnd deleted the remove_end_status branch May 11, 2015 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return value of end is never checked

3 participants