fix(docs): logo invisible on Jekyll page in OS dark mode#34
Merged
Conversation
…match The <picture> element selected logo-dark.svg (white ink) based on the OS-level prefers-color-scheme:dark, even though the Jekyll page renders a white background. White ink on white = invisible wordmark. The GitHub README's <picture> works correctly because GitHub applies its own theme-matched dark/light CSS. The Jekyll page doesn't — it just inherits the OS preference. Fixed by using a plain <img> with the original black-ink logo.svg on the Jekyll page only. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<picture>withprefers-color-scheme: darkselected the white-ink logo even though the Jekyll page has a white background. OS dark mode ≠ page dark theme. Replaced with a plain<img src="logo.svg">(black ink, always legible on the white Jekyll page). The GitHub README keeps its<picture>— GitHub's own theme system handles it correctly there.🤖 Generated with Claude Code