Draft
Conversation
This commit introduces a comprehensive test suite for the `SmartBuildingsDataset` class in `smart_control/dataset/dataset.py`.
The tests cover the following functionalities:
- Initialization (`__init__`):
- Verifies that the `download()` method is called by default.
- Verifies that `download()` is not called when `download=False`.
- Data Downloading (`download`):
- Mocks network requests and file operations to simulate successful downloads.
- Tests handling of network errors (`requests.exceptions.RequestException`, `requests.exceptions.HTTPError`) during download.
- Floorplan Retrieval (`get_floorplan`):
- Tests successful loading of floorplan and device layout map data.
- Mocks file system interactions (`np.load`, `json.load`).
- Ensures `ValueError` is raised for invalid building names.
- Building Data Retrieval (`get_building_data`):
- Tests successful loading of building data and metadata.
- Mocks file system interactions (`np.load`, `pickle.load`).
- Verifies correct loading of additional metadata (`device_infos`, `zone_infos`) when not present in the primary metadata file.
- Ensures `ValueError` is raised for invalid building or partition names.
The new test file is `smart_control/dataset/dataset_test.py` and includes 11 test cases in total, utilizing `unittest.mock` for isolating the class from external dependencies like network and file system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added unit tests for SmartBuildingsDataset.
This commit introduces a comprehensive test suite for the
SmartBuildingsDatasetclass insmart_control/dataset/dataset.py.The tests cover the following functionalities:
__init__):download()method is called by default.download()is not called whendownload=False.download):requests.exceptions.RequestException,requests.exceptions.HTTPError) during download.get_floorplan):np.load,json.load).ValueErroris raised for invalid building names.get_building_data):np.load,pickle.load).device_infos,zone_infos) when not present in the primary metadata file.ValueErroris raised for invalid building or partition names.The new test file is
smart_control/dataset/dataset_test.pyand includes 11 test cases in total, utilizingunittest.mockfor isolating the class from external dependencies like network and file system.