Draft
Conversation
…ing` directory to include the Python files in that module and its subdirectories in the Bazel build. The new BUILD file defines `pytype_strict_library` targets for all Python files and includes dependencies for each target. No other BUILD files were modified as they already covered all other Python files in the project.
…module.
This change implements your feedback to have separate BUILD files in each subdirectory of the `smart_control/reinforcement_learning` module.
Here's what I did:
- I removed the monolithic BUILD file from `smart_control/reinforcement_learning`.
- I added new BUILD files to each of the following subdirectories:
- `smart_control/reinforcement_learning/agents/networks/`
- `smart_control/reinforcement_learning/agents/`
- `smart_control/reinforcement_learning/observers/`
- `smart_control/reinforcement_learning/policies/`
- `smart_control/reinforcement_learning/replay_buffer/`
- `smart_control/reinforcement_learning/scripts/`
- `smart_control/reinforcement_learning/utils/`
- Each new BUILD file defines `pytype_strict_library` targets for the Python files in its respective directory and includes dependencies, including those between these subdirectories.
- I reviewed other BUILD files in the project; no further updates were necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.