Added "alert on connect", changed design a little#68
Draft
fluffyspace wants to merge 14 commits intos4ysolutions:masterfrom
Draft
Added "alert on connect", changed design a little#68fluffyspace wants to merge 14 commits intos4ysolutions:masterfrom
fluffyspace wants to merge 14 commits intos4ysolutions:masterfrom
Conversation
Author
|
I found new bugs I introduced. I will repair them before opening the pull request again. |
Author
|
@dsame will you check it out? |
dsame
force-pushed
the
master
branch
3 times, most recently
from
ff5b79f to
f83aa5d
Compare
Contributor
|
@fluffyspace Sorry for delay, this app is free and am not able to react only as soon as possible. Besides that I was busy with the big refactoring needed to make support easier. Now PR has conflicts because the codebase has changed a lot. Can you please update the PR. I am interested about improving aesthetic but have no talent for this :) |
Resolved conflicts while preserving PR features: - Alert modes (on connect, on disconnect, both, none) - Reconnect mode toggle - Passive scanner mode - Shake animations - Device opacity based on connection status Updated to upstream SDK versions (minSdk 23, targetSdk 34) and modern Bluetooth permissions (BLUETOOTH_CONNECT, BLUETOOTH_SCAN) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
@dsame Finally got around to this - thanks for not closing it on me after all this time! I'm not done, there are some errors now... |
- Enable BuildConfig generation in itagble module - Add missing connect() method to BLEPeripheralDefault to satisfy interface - Add missing REQUEST_ENABLE_LOCATION constant in MainActivity - Fix method name: isDisconnectAlert() → isDisconnectAlertOn() Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. First of all, thank you for an amazing application and making it free and open source. It's not easy being the only contributor. I love the code you wrote.
I modified the application because I have a cat and I need to get a notification when it comes in range. It would also be amazing to add "passive mode" which wouldn't connect to iTag but rather capture Bluetooth advertisements so that more devices can listen to it. I'm aware that in passive mode the iTag doesn't send advertisements as often as in connected mode but it would be a nice feature.
This is the first time I'm contributing to a project on GitHub, I hope i didn't do bad. I checked for bugs and I couldn't find any, but I'm sure there are some because it's hard to be flawless.
What I did: