-
Notifications
You must be signed in to change notification settings - Fork 70
feature(search): support searchNormalize for Greek and Cyrillic characters #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gnbm
wants to merge
13
commits into
master
Choose a base branch
from
gm/new-languages-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
00423cf
Strip Unicode combining marks in normalizeString
gnbm ff1dadc
Improve string normalization; add tests
gnbm 6222556
Rebuild distribution files
gnbm 4514a44
Create settings.local.json
gnbm aa6afcf
Create PULL_REQUEST_TEMPLATE.md
gnbm df15db8
Update deps
gnbm db429d1
Delete settings.local.json
gnbm 7d3056a
Add examples for search without normalization
gnbm 4eddec8
Use Unicode property regex for combining marks
gnbm 1a8c16c
Rebuild virtual-select distro and docs assets
gnbm 36e45ba
Hoist combining marks regex to module scope
gnbm 7757ff1
Expand multilingual search tests; update builds/docs
gnbm cd3c4c3
Add multi-language search examples and tests
gnbm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| Issue number: resolves # | ||
|
|
||
| --------- | ||
|
|
||
| <!-- Please do not submit updates to dependencies unless it fixes an issue. --> | ||
|
|
||
| <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> | ||
|
|
||
| ## What is the current behavior? | ||
| <!-- Please describe the current behavior that you are modifying. --> | ||
|
|
||
| ## What is the new behavior? | ||
| <!-- Please describe the behavior or changes that are being added by this PR. --> | ||
|
|
||
| - | ||
| - | ||
| - | ||
|
|
||
| ## Does this introduce a breaking change? | ||
|
|
||
| - [ ] Yes | ||
| - [ ] No | ||
|
|
||
| <!-- | ||
| If this introduces a breaking change: | ||
| 1. Describe the impact and migration path for existing applications below. | ||
| 2. Update the BREAKING.md file with the breaking change. | ||
| 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. | ||
| --> | ||
|
|
||
|
|
||
| ## Other information | ||
|
|
||
| <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new
describeblocks are missing the usualgo to sectionsetup, making them order-dependent (they only work if a previous test already navigated to the correct docs section). To keep the suite robust and consistent with the rest of the file, add acy.goToSection(...)in abeforeEach/firstitfor this block (and the other new blocks below).