Migrate from npm to pnpm by Wendystraite · Pull Request #91 · saasquatch/bunshi

Wendy Fouchter (Wendystraite) · 2025-10-11T11:07:36Z

Description of the change

Npm is really a pain when working with multiple projects.

This PR migrates from npm to pnpm with the following changes mades :

Code changes

Remove all package-lock.json by pnpm-lock.yaml.
Add "packageManager" field to package.json
Replace "npm-run-all" by "pnpm --parallel". Also don't launch multiple times browsers tests by not launching "test:browsers" and "test:browsers-suite" from "test" script.
Replace jotai-vue by @nanostores/vue inside example-vue since jotai-vue is not published anymore on npm.
Fix website's packages versions since it did not build when installed.

This also indirectly fixes #84 without typescript config changes.

CI changes

Update github workflows from npm to pnpm

Tested all workflows locally using act :

act -l
act pull_request -W .github/workflows/validate-pr.yml
act push -W .github/workflows/website.yml
act push -W .github/workflows/merge-to-main.yml

The first workflow passes, the second and third don't due to invalid credentials (expected).

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation or Development tools (readme, specs, tests, code formatting)

changeset-bot · 2025-10-11T11:07:40Z

⚠️ No Changeset found

Latest commit: 201d721

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot

Pull Request Overview

This PR migrates the project from npm to pnpm package manager to improve multi-project workflow efficiency. The migration includes replacing package lock files, updating scripts to use pnpm commands, and fixing package version inconsistencies that prevented builds.

Replace npm with pnpm throughout the project, including lock files and package manager configuration
Update all npm scripts to use pnpm equivalents with proper parallel/sequential execution patterns
Replace jotai-vue with @nanostores/vue in Vue example due to package availability issues

Reviewed Changes

Copilot reviewed 9 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
package.json	Main package configuration with pnpm scripts and packageManager field
website/package.json	Website dependencies with fixed versions for build compatibility
website/pnpm-workspace.yaml	PNPM workspace configuration for website
website/README.md	Updated documentation to reference pnpm commands
examples/old-typescript/package.json	Added missing dependencies for TypeScript example
examples/example-vue/package.json	Migrated from jotai-vue to @nanostores/vue
examples/example-vue/src/components/HelloWorld.vue	Updated Vue component to use nanostores API
examples/example-vue/src/Molecules.ts	Updated molecule definition to use nanostores
CONTRIBUTING.md	Updated contributor documentation with pnpm commands

Files not reviewed (7)

examples/example-react/pnpm-lock.yaml: Language not supported
examples/example-vanilla/package-lock.json: Language not supported
examples/example-vanilla/pnpm-lock.yaml: Language not supported
examples/example-vue/package-lock.json: Language not supported
examples/example-vue/pnpm-lock.yaml: Language not supported
examples/old-typescript/package-lock.json: Language not supported
examples/old-typescript/pnpm-lock.yaml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

package.json

Copilot

Pull Request Overview

Copilot reviewed 12 out of 24 changed files in this pull request and generated no new comments.

Files not reviewed (7)

examples/example-react/pnpm-lock.yaml: Language not supported
examples/example-vanilla/package-lock.json: Language not supported
examples/example-vanilla/pnpm-lock.yaml: Language not supported
examples/example-vue/package-lock.json: Language not supported
examples/example-vue/pnpm-lock.yaml: Language not supported
examples/old-typescript/package-lock.json: Language not supported
examples/old-typescript/pnpm-lock.yaml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 12 out of 24 changed files in this pull request and generated 1 comment.

Files not reviewed (7)

examples/example-react/pnpm-lock.yaml: Language not supported
examples/example-vanilla/package-lock.json: Language not supported
examples/example-vanilla/pnpm-lock.yaml: Language not supported
examples/example-vue/package-lock.json: Language not supported
examples/example-vue/pnpm-lock.yaml: Language not supported
examples/old-typescript/package-lock.json: Language not supported
examples/old-typescript/pnpm-lock.yaml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

examples/example-vue/src/components/HelloWorld.vue

Logan Volkers (loganvolkers) · 2025-11-17T22:40:01Z

Wendy Fouchter (@Wendystraite) please update your PR on top of main to resolve merge conflicts.

- Remove all `package-lock.json` by `pnpm-lock.yaml`. - Add "packageManager" field to package.json - Replace "npm-run-all" by "pnpm --parallel". Also don't launch multiple times browsers tests by not launching "test:browsers" and "test:browsers-suite" from "test" script. - Replace `jotai-vue` by `@nanostores/vue` inside example-vue since jotai-vue is not published anymore on npm. - Fix website's packages versions since it did not build when installed.

- Update actions/checkout@v3 to v4 - Add pnpm/action-setup@v4 - Update actions/setup-node@v3 to v4 - Use pnpm cache - Replace all "npm" calls to "pnpm" - Replace all "npx" calls to "pnpm exec" - Test all workflows locally using "act"

Copilot AI review requested due to automatic review settings October 11, 2025 11:07

Copilot AI reviewed Oct 11, 2025

View reviewed changes

package.json Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

Wendy Fouchter (Wendystraite) marked this pull request as draft October 11, 2025 11:08

Copilot AI review requested due to automatic review settings October 11, 2025 11:39

Copilot AI reviewed Oct 11, 2025

View reviewed changes

Wendy Fouchter (Wendystraite) marked this pull request as ready for review October 11, 2025 11:41

Wendy Fouchter (Wendystraite) requested a review from Copilot October 11, 2025 11:42

Copilot AI reviewed Oct 11, 2025

View reviewed changes

examples/example-vue/src/components/HelloWorld.vue Show resolved Hide resolved

Wendy Fouchter (Wendystraite) mentioned this pull request Oct 11, 2025

Fix broken test:typings due to parent node_modules node types. #84

Merged

4 tasks

Wendy Fouchter (Wendystraite) added 3 commits November 18, 2025 10:38

Update github workflows from npm to pnpm

a20d750

- Update actions/checkout@v3 to v4 - Add pnpm/action-setup@v4 - Update actions/setup-node@v3 to v4 - Use pnpm cache - Replace all "npm" calls to "pnpm" - Replace all "npx" calls to "pnpm exec" - Test all workflows locally using "act"

Fix typo for "test:browsers" script

201d721

Wendy Fouchter (Wendystraite) force-pushed the npm_to_pnpm branch from 0b6335c to 201d721 Compare November 18, 2025 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate from npm to pnpm#91

Migrate from npm to pnpm#91
Wendy Fouchter (Wendystraite) wants to merge 3 commits intosaasquatch:mainfrom
Wendystraite:npm_to_pnpm

Wendy Fouchter (Wendystraite) commented Oct 11, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Logan Volkers (loganvolkers) commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

Wendy Fouchter (Wendystraite) commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the change

Code changes

CI changes

Type of change

Uh oh!

changeset-bot bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Logan Volkers (loganvolkers) commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Wendy Fouchter (Wendystraite) commented Oct 11, 2025 •

edited

Loading

changeset-bot bot commented Oct 11, 2025 •

edited

Loading