Add new decorated components and update dependencies#17
Open
Teodor Kulej (mt3o) wants to merge 1 commit intosaasquatch:mainfrom
Open
Add new decorated components and update dependencies#17Teodor Kulej (mt3o) wants to merge 1 commit intosaasquatch:mainfrom
Teodor Kulej (mt3o) wants to merge 1 commit intosaasquatch:mainfrom
Conversation
Introduced `DecoratedComponentTest` and `DecoratedComponentTestFail` in `components.tsx` with decorator `WithStencilHooks`. Also, updated various dependencies in `package.json` and `package-lock.json` to newer versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great lib you have created!
I thought it would be nice to leverage decorator to implement the hooks, instead of explicitly calling the function within the constructor. Additionally, it would be nice to enforce the presence of stencil hook methods. This is what i came with.
I had problems making the tests to run locally, even with your branch. Please review.
Description of the change
Implement class decorator to apply hooks instead of expecting the call to be executed directly in the constructor.
Type of change
Checklists
Development
Paperwork
Code review