chore: enhance devcontainer with credential mounts and tool updates#67
chore: enhance devcontainer with credential mounts and tool updates#67
Conversation
- Mount opencode config directory for persistent settings - Mount opencode auth.json for authentication credentials - Mount .codex directory for codex credentials - Update opencode from 1.1.8 to 1.1.12 - Update codex from v0.79.0 to v0.80.0 - Add postCreateCommand to ensure correct directory permissions
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR claims to enhance security by making devcontainer credential mounts readonly, but the actual implementation is incomplete. The changes add new mount configurations and update some feature versions, but critically fail to include the readonly parameters that are the stated purpose of the PR.
Changes:
- Added three bind mounts for credential files (.config/opencode, .local/share/opencode/auth.json, .codex)
- Updated opencode feature version from 1.1.8 to 1.1.12
- Updated codex release tag from rust-v0.79.0 to rust-v0.80.0
- Added postCreateCommand to set up .local directory permissions
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c8bab00a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add readonly=true to .config/opencode mount - Add readonly=true to .local/share/opencode/auth.json mount - Add readonly=true to .codex mount This prevents accidental modifications to sensitive credential files during development.
- Extract postCreateCommand into .devcontainer/deno-and-tools/post-create.sh - Fix codex mount to target specific auth.json file instead of entire directory - Add /home/vscode/.codex directory creation to post-create script
sachitv
changed the title
Summary
Changes
.devcontainer/deno-and-tools/devcontainer.json: Version bumps, credential mounts configuration, and postCreateCommand extraction.devcontainer/deno-and-tools/post-create.sh: New script to handle directory creation and permissions.devcontainer/deno-only/devcontainer.json: Deno version bump to 2.6.4Testing