Skip to content

fix(inference): use config fields instead of hardcoded max_seq_length/load_in_4bit #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sacredvoid merged 1 commit into from
Mar 26, 2026
Merged

fix(inference): use config fields instead of hardcoded max_seq_length/load_in_4bit #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/alignrl/inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ class InferenceConfig(BaseModel):
max_tokens: int = 512
top_p: float = 0.9
backend: str = "unsloth" # "unsloth", "vllm", or "mlx"
max_seq_length: int = 2048
load_in_4bit: bool = True


def build_prompt(user_message: str, system: str | None = None) -> list[dict[str, str]]:
Expand Down Expand Up @@ -48,8 +50,8 @@ def _load_unsloth(self) -> None:
model_path = self.config.adapter_path or self.config.model_name
self._model, self._tokenizer = FastLanguageModel.from_pretrained(
model_name=model_path,
max_seq_length=2048,
load_in_4bit=True,
max_seq_length=self.config.max_seq_length,
load_in_4bit=self.config.load_in_4bit,
)
from alignrl.config import ensure_chat_template

Expand Down
Loading