Skip to content

fix: apply proxy url in runner#2

Open
doron-cohen wants to merge 1 commit intosadopc:mainfrom
doron-cohen:fix/apply-proxy-url-in-runner
Open

fix: apply proxy url in runner#2
doron-cohen wants to merge 1 commit intosadopc:mainfrom
doron-cohen:fix/apply-proxy-url-in-runner

Conversation

@doron-cohen
Copy link
Copy Markdown

Summary

Per-request proxy_url field exists in the collection schema and the HTTP client already supports it, but buildProtocolRequest() in the runner never copies it from the collection request to the protocol request. This means proxy_url set in .gottp.yaml files is silently ignored in both headless and TUI mode.

Changes

  • Copy ProxyURL from collection request to protocol request in buildProtocolRequest()

Related Issues

Closes #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Testing

  • All existing tests pass (make test)
  • New tests added for changes
  • Linter passes (make lint)
  • Manually tested in headless CLI mode (if applicable)

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have added tests that prove my fix/feature works
  • New and existing tests pass locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant