Conversation
- Add comprehensive comments to txs.env explaining all variables - Add detailed comments to cgw.env for variables without documentation - Document purpose, format, and production security considerations - Update nginx.conf and ui.env with necessary configurations
Fbartoli
requested review from
a team,
Uxio0,
falvaradorodriguez and
moisses89
and removed request for
a team
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| DEBUG=0 | ||
|
|
||
| # Django debug mode - enables detailed error pages (set to 0 in production) | ||
| DEBUG=1 |
There was a problem hiding this comment.
Debug mode enabled contradicts production settings and comment
The DEBUG value was changed from 0 to 1, which directly contradicts the comment on line 11 that says "set to 0 in production" and conflicts with DJANGO_SETTINGS_MODULE=config.settings.production. Enabling Django debug mode exposes detailed error pages with sensitive information like stack traces, local variables, and configuration settings. This appears to be accidentally committed debug configuration that wasn't reverted before merging.
There was a problem hiding this comment.
@Fbartoli Please, could you review it? I agree with the Cursor comment
|
|
||
| # Authentication & Security | ||
| # Authorization token for privileged endpoints - MUST be changed in production | ||
| AUTH_TOKEN=local_development_token |
There was a problem hiding this comment.
Auth tokens between services no longer match
The AUTH_TOKEN in cgw.env was changed from your_privileged_endpoints_token to local_development_token, but the corresponding CGW_AUTH_TOKEN in cfg.env still has the value your_privileged_endpoints_token. According to the documentation, these tokens must match for the Config Service to authenticate with the Client Gateway. This mismatch will cause webhook authentication failures between services, breaking cache invalidation functionality.
2 participants
Note
Provides clearer environment configuration across services with documented examples and local-dev defaults.
.env.samplewith annotated sections (RPC, ports, service versions) and example valuescontainer_env_files/cgw.env: extensive comments, optional feature flags, Redis/AMQP/CORS settings, Safe Config URL, and required dummy secrets/keys for local developmentcontainer_env_files/txs.env: detailed comments, DEBUG/log level, DB/Redis/Celery URLs, CSRF/hosts, and events queue settingscontainer_env_files/ui.env: adds WalletConnect/project flags, Mixpanel tokens, local CGW URLs, ESLint disable flag, and optional wallet keysWritten by Cursor Bugbot for commit 0bf7657. This will update automatically on new commits. Configure here.