fix(watch): keep update outputs project-relative#434
Open
takeItIzzy wants to merge 1 commit intosafishamsi:v4from
Open
fix(watch): keep update outputs project-relative#434takeItIzzy wants to merge 1 commit intosafishamsi:v4from
takeItIzzy wants to merge 1 commit intosafishamsi:v4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #433.
graphify updateshould keep generated paths project-relative for code-only rebuilds, matching the rest of the pipeline.Root cause
graphify.watch._rebuild_code()resolved the requested path before detection and report generation. That changed a relative invocation such asgraphify update .into an absolute rebuild root, which then leaked absolute paths into:graphify-out/graph.jsonsource_filefieldsgraphify-out/GRAPH_REPORT.mdtitle and path-bearing sectionsgraphify-out/graph.htmltitle and node metadatagraphify-out/cache/*.jsonAST cache entriesWhat changed
graphify update .usagesource_filevalues before report/JSON/HTML export.caseValidation
.venv/bin/python -m pytest -q tests/test_watch.py.venv/bin/python -m pytest -q tests/test_pipeline.py.venv/bin/python -m graphify update .in a temporary repo, verifying no absolute project paths ingraph.json,GRAPH_REPORT.md,graph.html, orgraphify-out/cache/*.json