fix: add BCL method blocklist to cross-file inference#440
Open
V0v1kkk wants to merge 1 commit intosafishamsi:v4from
Open
fix: add BCL method blocklist to cross-file inference#440V0v1kkk wants to merge 1 commit intosafishamsi:v4from
V0v1kkk wants to merge 1 commit intosafishamsi:v4from
Conversation
When resolving unresolved calls across files, common .NET BCL method names (Contains, Equals, ToString, Where, Select, ListAsync, etc.) would incorrectly match graph nodes with the same name, creating false INFERRED edges. For example, string.Contains() would create a spurious edge to an F# union case named "Contains". Add a blocklist of ~120 common BCL/framework method names that are skipped during cross-file call resolution. Made-with: Cursor
V0v1kkk
added a commit
to V0v1kkk/graphify
that referenced
this pull request
Apr 18, 2026
Add upstream contribution status: 3 graphify PRs (safishamsi#440-safishamsi#442), 1 tree-sitter-razor PR (safishamsi#19), 1 tree-sitter-fsharp issue (safishamsi#176). Document fork locations, blocked PRs, and final test metrics. Fix document structure (reorder commit 7, remove duplicated sections). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437
Summary
Adds a blocklist of ~120 common .NET BCL/framework method names (
Contains,Equals,ToString,Where,Select,Add,Remove,AddDbContext,AddSingleton,LogInformation, etc.) that are skipped during cross-file call resolution.Without this, the cross-file inference creates hundreds of false
INFERREDedges because common method names match unintended nodes — e.g.string.Contains()matches an F# union caseEdgeRelation.Contains.Impact
Tested on a mixed F#/C#/Blazor project (141 code files):
Contains(false positive) →BookService(correct)The blocklist follows the same pattern as the existing
_SKIP_LABELSset but targets method names. It's conservative — only blocks names that are extremely common across .NET codebases and almost never represent meaningful cross-file relationships.Test Plan