fix: GMP now stores the original packet#136
Draft
facundomedica wants to merge 1 commit intorelease/3.0from
Draft
fix: GMP now stores the original packet#136facundomedica wants to merge 1 commit intorelease/3.0from
facundomedica wants to merge 1 commit intorelease/3.0from
Conversation
ashishchandr70
suggested changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Can you also add some tests, and perhaps some notes about how to test this from an end user perspective?
It is also not compiling at the moment so fix that too please.
The other aspect to consider is that this is a change to SSC and will require a chain halt and upgrade i.e. will need an upgrade handler. Is there an interim solution outside of SSC that does not require a chain halt and upgrade, which can then be implemented as the permanent solution to this issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.