Skip to content

Custom genesis validators#61

Draft
lukitsbrian wants to merge 6 commits intomainfrom
feature/genesis-validators
Draft

Custom genesis validators#61
lukitsbrian wants to merge 6 commits intomainfrom
feature/genesis-validators

Conversation

@lukitsbrian
Copy link
Copy Markdown
Contributor

Enables a flag to set custom genesis validators when launching a chainlet. This will be gated to admins only, and is intended for use only during the migration of chainlets.

@rkollar
Copy link
Copy Markdown
Contributor

rkollar commented Sep 23, 2025

Why do we need to know genesis validators?

@lukitsbrian
Copy link
Copy Markdown
Contributor Author

Why do we need to know genesis validators?

It is for data consistency regarding what is currently stored on SPC, since there is an existing field for genesis validators in each chainlet object.

This field is currently populated by the existing validator set, which we shouldn't be using when the chainlets are being relaunched.

@rkollar
Copy link
Copy Markdown
Contributor

rkollar commented Sep 23, 2025

which we shouldn't be using when the chainlets are being relaunched.

But why does that matter for chainlets that already have a genesis file?

@lukitsbrian lukitsbrian force-pushed the feature/genesis-validators branch from 07c07fc to 175f0fe Compare September 23, 2025 20:43
@lukitsbrian
Copy link
Copy Markdown
Contributor Author

But why does that matter for chainlets that already have a genesis file?

It shouldn't matter right now - the goal is to keep consistent state between what we have in SPC and what's being migrated into SSC.

It might also be helpful to ensure that all chainlets have this field populated, in case we want to pull this genesis info directly from the chain in the future.

@rkollar
Copy link
Copy Markdown
Contributor

rkollar commented Sep 23, 2025

It shouldn't matter right now - the goal is to keep consistent state between what we have in SPC and what's being migrated into SSC.

But that doesn't answer the question why. If it's not useful then it doesn't make sense to put extra effort into having it. The reason we have it in SPC is to have the set of validators at the start of the chainlet in a way that isn't racy. But on SSC we can't use this anyway since we can't get the validator set on-chain, so originally the decision was to have it in S3. So SSC isn't going to have this feature for new chainlets anyway. And for old ones it should be useless.

So the S3 solution isn't going to be used anymore?

@lukitsbrian
Copy link
Copy Markdown
Contributor Author

So SSC isn't going to have this feature for new chainlets anyway.

If this is the case we should remove genesisValidators from the proto completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants