Use structured error types for fee denom validation in CreateChainletStack#76
Draft
Use structured error types for fee denom validation in CreateChainletStack#76
Conversation
Co-authored-by: lukitsbrian <45702419+lukitsbrian@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on fee denom support in escrow
Use structured error types for fee denom validation in CreateChainletStack
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error handling for unsupported fee denominations was inconsistent between
CreateChainletStack(usingfmt.Errorf) andupdateChainletStackFees(usingcosmossdkerrors.Wrapfwithtypes.ErrInvalidDenom).Changes
cosmossdkerrorsimport tomsg_server_create_chainlet_stack.gofmt.Errorfwithcosmossdkerrors.Wrapf(types.ErrInvalidDenom, ...)for denom validation errorsThis enables programmatic error type checking and aligns with the existing pattern:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.