Skip to content

Fix an occurrence of lazy_import #40541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Aug 3, 2025

Previously the following code fails if executed right after Sage starts:

P.<x,y,z> = ProjectiveSpace(QQ, 2)
C = Curve([(x^2 + y^2 - y*z - 2*z^2)*(y*z - x^2 + 2*z^2)*z + y^5], P)
C.ordinary_model()

The error is:

NotImplementedError: object does not support iteration

This pull request fixes it. The reason why it is fixed is explained in the code edit.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Aug 4, 2025

Documentation preview for this PR (built with commit fc26616; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@JosePisco JosePisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended on my end (version 10.7.beta9). Thanks for the fix.

@JosePisco
Copy link
Contributor

I don't have the permission to change labels, someone else will have to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants