Skip to content

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Sep 20, 2025

See the new test, previously it fails.

The n_Z2m ring creation is caused by #39075.

Singular source code contains

      // is exponent <=2^(8*sizeof(unsigned long))
      mp_bitcnt_t l=mpz_scan1 (modBase,0);
      if ((l>0) && (l<=8*sizeof(unsigned long)))
      {

so the limit is taken from there.

The polynomial comparison fix is workaround for Singular/Singular#1293. #39018 touches this part of the code, although I think it doesn't introduce the bug.

Fix #40838

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 force-pushed the fix-singular-z2m branch 2 times, most recently from 052cbc8 to 23522a2 Compare September 20, 2025 12:04
Copy link

Documentation preview for this PR (built with commit 4d557f2; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow in singular polynomial rings
1 participant