some fixes from ruff UP warnings #41158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit ad04953; changes) is ready! 🎉 |
vincentmacri
added
s: positive review
t: refactoring
and removed
s: needs review
labels
Member
|
Looks good! You can add these rules to the CI like I did in #41108 if you want (in which case you might might to make this PR depend on that one otherwise we'll have merge conflicts). If you don't want to, I plan to fix some other UP rules soon and I can just enable the ones you fixed here when I do that. |
vincentmacri
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about UP022, UP015 and UP034
https://docs.astral.sh/ruff/rules/#pyupgrade-up
📝 Checklist