[camera] Add protection around DroidMediaCamera pointer in CameraListener#59
Open
peat-psuwit wants to merge 1 commit intosailfishos:masterfrom
Open
[camera] Add protection around DroidMediaCamera pointer in CameraListener#59peat-psuwit wants to merge 1 commit intosailfishos:masterfrom
peat-psuwit wants to merge 1 commit intosailfishos:masterfrom
Conversation
peat-psuwit
force-pushed
the
fix-camera-uaf
branch
from
a2d02f8 to
85750aa
Compare
…ener When destroying DroidMediaCamera, CameraListener held inside an ongoing callback can outlive the destroying instance. To prevent it from accessing DroidMediaCamera after being destroyed, one needs to remove the reference to DroidMediaCamera inside the listener before deleting it. As this removal happens in a different thread then callbacks, a mutex is required to prevent race condition. Also, just to be safe, remove the listener from the Android Camera instance as well.
peat-psuwit
force-pushed
the
fix-camera-uaf
branch
from
85750aa to
7a22634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When destroying DroidMediaCamera, CameraListener held inside an ongoing
callback can outlive the destroying instance. To prevent it from
accessing DroidMediaCamera after being destroyed, one needs to remove
the reference to DroidMediaCamera inside the listener before deleting
it.
As this removal happens in a different thread then callbacks, a mutex is
required to prevent race condition. Also, just to be safe, remove the
listener from the Android Camera instance as well.