[droidmedia] Limit the exported symbols to the public API. Contributes to JB#49426#69
Open
adenexter wants to merge 1 commit intosailfishos:masterfrom
Open
[droidmedia] Limit the exported symbols to the public API. Contributes to JB#49426#69adenexter wants to merge 1 commit intosailfishos:masterfrom
adenexter wants to merge 1 commit intosailfishos:masterfrom
Conversation
Member
|
|
Contributor
Author
|
DroidMediaAllocator is referenced from the the services.h files but those aren't installed so only exposing startMiniSurfaceFlinger should be enough. |
Member
|
but DroidMediaAllocator is still exposed, if I'm not mistaken, which is why I asked. |
Contributor
Author
|
Exposed because the allocator.h header is installed which along with private.h seems to be an oversight, or somewhere else? |
Contributor
Author
|
Now I understand, I didn't change the compile arguments for libminisf.so. So it still exports everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.