Skip to content

[droidmedia] Limit the exported symbols to the public API. Contributes to JB#49426#69

Open
adenexter wants to merge 1 commit intosailfishos:masterfrom
adenexter:jb49426
Open

[droidmedia] Limit the exported symbols to the public API. Contributes to JB#49426#69
adenexter wants to merge 1 commit intosailfishos:masterfrom
adenexter:jb49426

Conversation

@adenexter
Copy link
Copy Markdown
Contributor

No description provided.

@monich
Copy link
Copy Markdown
Member

monich commented Aug 4, 2020

objdump -T libdroidmedia.so looks clean. Does DroidMediaAllocator need to be exposed from libminisf.so or would startMiniSurfaceFlinger be enough?

@adenexter
Copy link
Copy Markdown
Contributor Author

DroidMediaAllocator is referenced from the the services.h files but those aren't installed so only exposing startMiniSurfaceFlinger should be enough.

@monich
Copy link
Copy Markdown
Member

monich commented Aug 17, 2020

but DroidMediaAllocator is still exposed, if I'm not mistaken, which is why I asked.

@adenexter
Copy link
Copy Markdown
Contributor Author

Exposed because the allocator.h header is installed which along with private.h seems to be an oversight, or somewhere else?

@adenexter
Copy link
Copy Markdown
Contributor Author

Now I understand, I didn't change the compile arguments for libminisf.so. So it still exports everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants