Fix 12 bugs in hand-written files, templates, and build scripts

[luke-hagar-sp]

Summary

Cross-SDK audit identified 12 bugs in the PowerShell SDK across hand-written files, mustache templates, and build scripts. Template fixes will propagate to generated code on next make build.

Bug Fixes

Critical

PS1: C-style // comment is invalid PowerShell — causes runtime error on array query params

• sdk-resources/resources/api_client.mustache L107: if ($Parameter.Value.Count -gt 1) { // array — PowerShell doesn't support // comments. This causes a parse error whenever an API call includes array-valued query parameters.
• Fix: Changed // to #.

PS2: Inverted anyOf match condition breaks all anyOf deserialization

• sdk-resources/resources/model_anyof.mustache L71: if ($match -ne 0) — $match starts at 0 and increments on match. The condition -ne 0 is $false on the first iteration, so the first anyOf type is never attempted, and no subsequent types can match either.
• Fix: Changed to if ($match -eq 0).

PS3: Get-Config returns undefined local $Configuration instead of script-scoped variable

• PSSailpoint/Configuration.ps1 L324: return $Configuration returns an undefined local variable. When neither env nor local config succeeds, this returns $null, causing a null reference on $Configuration.BaseUrl[-1] in Get-DefaultConfiguration.
• Fix: Changed to return $Script:Configuration.

Medium

PS4: URL validation regex '[http|https]' is a character class, not alternation

• PSSailpoint/Configuration.ps1 L149: [http|https] matches individual characters h, t, p, s, | — not the strings "http" or "https". This accepts URLs with schemes like ftp, ssh, etc.
• Fix: Changed to '^https?$'.

PS5: Cannot set $Experimental to $false, or retry values to 0

• PSSailpoint/Configuration.ps1 L175, L179, L183: If ($Experimental), If ($MaximumRetryCount), If ($RetryIntervalSeconds) all skip falsy values ($false, 0).
• Fix: Changed each to If ($PSBoundParameters.ContainsKey('...')).

PS6: Proxy cleared unconditionally when not passed to Set-DefaultConfiguration

• PSSailpoint/Configuration.ps1 L192-194: The else branch of the proxy check sets $Script:Configuration['Proxy'] = $null even when the user didn't pass -Proxy at all, clearing any previously configured proxy.
• Fix: Changed else to elseif ($PSBoundParameters.ContainsKey('Proxy')).

PS7: Same regex bug as PS4 in generated configuration template

• sdk-resources/resources/configuration.mustache L135: Same '[http|https]' character class bug.
• Fix: Changed to '^https?$'.

Low

PS8 + PS9: Hardcoded Search-Post and undefined $Function in Invoke-PaginateSearch

• PSSailpoint/Pagination.ps1 L104: The search function was hardcoded to Search-Post, making it impossible to paginate Beta/V2024/V2025/V2026 search endpoints. The catch block also referenced $Function which was undefined.
• Fix: Added an optional $Function parameter (default "Search-Post" for backward compatibility) and use & $Function to invoke it dynamically. This also resolves the undefined $Function in the error handler.

PS10: Beta test calls V3 Get-Accounts instead of Get-BetaAccounts

• PSSailpoint/tests/Validation.Tests.ps1 L49: The Beta describe block's "Get-BetaAccounts" test was actually calling the V3 Get-Accounts function.
• Fix: Changed to Get-BetaAccounts.

PS11: Trailing comma in JSON test fixture causes parse error

• PSSailpoint/tests/Validation.Tests.ps1 L25: Trailing comma after "query": "*" is invalid JSON and causes ConvertFrom-JsonToSearch to fail.
• Fix: Removed the trailing comma.

PS12: Broken fs.stat() check in moveFiles() in postscript.js

• sdk-resources/postscript.js L70: Same issue as Go SDK — fs.stat() throws on missing path instead of returning falsy.
• Fix: Replaced with await fs.mkdir(destPath, { recursive: true }).

Verification

• Template fixes (PS1, PS2, PS7) verified by source inspection; will take effect on next make build
• Hand-written file changes verified by syntax inspection

Test plan

• Run Import-Module ./PSSailpoint/PSSailpoint.psm1 to verify module loads
• Test API call with array query parameters to verify PS1 fix
• Test anyOf deserialization (e.g., a model using anyOf schemas) to verify PS2 fix
• Run Invoke-Pester to verify test fixes (PS10, PS11)
• Test Set-DefaultConfiguration -Experimental $false to verify PS5 fix
• Test Set-DefaultConfiguration -BaseUrl "ftp://evil" is rejected by PS4 fix

🤖 Generated with Claude Code