Skip to content

REST api for team member#1

Open
sajithmohan wants to merge 2 commits intomasterfrom
develop
Open

REST api for team member#1
sajithmohan wants to merge 2 commits intomasterfrom
develop

Conversation

@sajithmohan
Copy link
Copy Markdown
Owner

REST APIS for resource team member
Tests for views and and phone, email model validation
Includes auto generated documentation using coreapi

@lalitpatel
Copy link
Copy Markdown

Hi @sajithmohan, Thank you for taking out time to work on the assignment.
Couple of observations:

  • I see that we are using TextField in place of CharField. Any reason for that?
  • Requirements doesn't seem to be frozen.

@sajithmohan
Copy link
Copy Markdown
Owner Author

@lalitpatel

  • TextField vs CharField: Since the database we are using is Mysql it should be CharField. this will give performance improvement in Mysql unlike Postgres in which both don't have any performance difference.

  • requirements : Didn't use freeze. added manually, missed versions because it is only for documentation and not have any impact on application apis. will update this with freeze output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants