Skip to content

[EXPERIMENTAL] Try out os kill instead of psutil to test on windows#1

Open
sakshie95 wants to merge 8 commits intofeature/queue_scoped_incremental_downloadsfrom
test/os-kill
Open

[EXPERIMENTAL] Try out os kill instead of psutil to test on windows#1
sakshie95 wants to merge 8 commits intofeature/queue_scoped_incremental_downloadsfrom
test/os-kill

Conversation

@sakshie95
Copy link
Copy Markdown
Owner

Fixes:

What was the problem/requirement? (What/Why)

What was the solution? (How)

What is the impact of this change?

How was this change tested?

See DEVELOPMENT.md for information on running tests.

  • Have you run the unit tests?
  • Have you run the integration tests?
  • Have you made changes to the download or asset_sync modules? If so, then it is highly recommended
    that you ensure that the docker-based unit tests pass.

Was this change documented?

  • Are relevant docstrings in the code base updated?
  • Has the README.md been updated? If you modified CLI arguments, for instance.

Does this PR introduce new dependencies?

This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.

  • This PR adds one or more new dependency Python packages. I acknowledge I have reviewed the considerations for adding dependencies in DEVELOPMENT.md.
  • This PR does not add any new dependencies.

Is this a breaking change?

A breaking change is one that modifies a public contract in a way that is not backwards compatible. See the
Public Contracts section
of the DEVELOPMENT.md for more information on the public contracts.

If so, then please describe the changes that users of this package must make to update their scripts, or Python applications.

Does this change impact security?

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • If so, then please label this pull request with the "security" label. We'll work with you to analyze the threats.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sakshie95 sakshie95 force-pushed the feature/queue_scoped_incremental_downloads branch 2 times, most recently from a778096 to b311922 Compare April 23, 2025 23:16
@sakshie95 sakshie95 force-pushed the feature/queue_scoped_incremental_downloads branch 4 times, most recently from 173b2a5 to 09bed6c Compare May 14, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant