Conversation
dfreeman
left a comment
dfreeman
left a comment
There was a problem hiding this comment.
This repo is apparently not set up for CI.
This repo probably hasn't been touched in a meaningful way since Travis still worked
This should probably be a major version bump?
This should be a major bump, since EAI@2 requires the host app to also have it installed IIRC.
Ultimately I think we should probably consider deprecating this package. Most of the work it originally did was getting debug into the build at all, but EAI makes that trivial. The only 'special sauce' left is automatically reading _debugContainerKey from the instance the logger is read from, which is of questionable value at this point compared to just setting an explicit key, IMO.
Regardless I'm happy to ship this change in the meantime 👍
|
|
||
| ## v2.1.1 - 04/09/2019 | ||
|
|
||
| This release fixes a bug introduced in `v2.1.0` — `debug@4` contains ES6 syntax that breaks compatibility with IE11. We now lock our `debug` dependency below version 4. |
There was a problem hiding this comment.
We could probably widen our acceptable version band now since EAI runs Babel against your imported dependencies these days
2 participants
Upgrade to ember-auto-import 2.x
This should probably be a major version bump?
This repo is apparently not set up for CI. But tests pass locally.